[prometheus-elasticsearch-exporter] Allow to override imageRegistry globally #4497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lobally Signed-off-by: Jeroen van Erp <[email protected]>
zeritti
requested changes
Apr 29, 2024
There was a problem hiding this comment.
Thank you, @hierynomus, for your PR. Please, see my comments below.
charts/prometheus-elasticsearch-exporter/templates/deployment.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Jeroen van Erp <[email protected]>
|
@zeritti Many thanks for the fast review. Comments are addressed. |
zeritti
approved these changes
Apr 29, 2024
wilfriedroset
pushed a commit
to wilfriedroset/helm-charts
that referenced
this pull request
May 8, 2024
…lobally (prometheus-community#4497) * [prometheus-elasticsearch-exporter] Allow to override imageRegistry globally Signed-off-by: Jeroen van Erp <[email protected]> * Incorporate review comments Signed-off-by: Jeroen van Erp <[email protected]> --------- Signed-off-by: Jeroen van Erp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lobally
What this PR does / why we need it
This PR allows to override the image registry for the
prometheus-elasticsearch-exporterusing aglobal.imageRegistryflag, which is a common way to override the registry when this chart is bundled as a sub-chart.The PR is made such that it is backwards compatible with the current version of the chart so that only a patch increment is needed according to semver.
Which issue this PR fixes
Special notes for your reviewer
@svenmueller @desaintmartin @zeritti
Checklist
[prometheus-couchdb-exporter])